show error when parsing with KaTeX #1738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into one issue and I'm not sure what standard procedure is to address since is not directly a part of this proposed change. These lines in
EmbedBlot
are throwing an error when I insert any formula, valid or invalid. I took look at git blame and found thatthis.contentNode
was introduced in the last two weeks, butthis
isundefined
because the function has a different context than the constructor. If that function is changed to an arrow function or.bind(this)
is added to the end, that fixes the issue.