Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error when parsing with KaTeX #1738

Merged
merged 1 commit into from
Oct 5, 2017
Merged

show error when parsing with KaTeX #1738

merged 1 commit into from
Oct 5, 2017

Conversation

arrocke
Copy link
Contributor

@arrocke arrocke commented Oct 4, 2017

  • Use KaTeX's built in error reporting instead of throwing an exception and logging to the console.
  • For KaTeX Parse error #1737

I ran into one issue and I'm not sure what standard procedure is to address since is not directly a part of this proposed change. These lines in EmbedBlot are throwing an error when I insert any formula, valid or invalid. I took look at git blame and found that this.contentNode was introduced in the last two weeks, but this is undefined because the function has a different context than the constructor. If that function is changed to an arrow function or .bind(this) is added to the end, that fixes the issue.

@jhchen jhchen merged commit 26896cc into slab:develop Oct 5, 2017
@jhchen
Copy link
Member

jhchen commented Oct 5, 2017

Thanks!

@arrocke arrocke deleted the katex-error branch October 5, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants